Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic sairedis changes for SAI SRV6 #905

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kperumalbfn
Copy link

sairedis changes to support SAI SRV6 changes - opencomputeproject/SAI@2e934ff

Update SAI SEGMENTROUTE object to SAI SRV6 object
Serialize and deserialize APIs for SRV6 MY_SID_ENTRY object

These changes are needed to update Sonic SAI refpoint with SRV6 changes.

SAI refpoint with SRV6 update and this PR has to be merged together.

@kperumalbfn
Copy link
Author

@kcudnik latest sairedis changes on top of your recent commits.

meta/SaiInterface.h Outdated Show resolved Hide resolved
@kperumalbfn
Copy link
Author

@kcudnik SAI tag with SRV6 changes is not yet created which is needed for Sonic 202111 release. This PR has to be merged along with that.

kcudnik
kcudnik previously approved these changes Aug 24, 2021
@kcudnik
Copy link
Collaborator

kcudnik commented Sep 1, 2021

can you also make unittsts in sairedis/unittest, you will find there directory structure and you can follow the format

@kperumalbfn
Copy link
Author

@kcudnik unittests are added for srv6

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 1, 2021

great, now please make this compile right :)

@kperumalbfn
Copy link
Author

great, now please make this compile right :)

@kcudnik This PR has SAI dependencies. Compilation will be successful only when SAI refpoint is updated.

We need SAI tag with the below commit, may be SAI 1.9 for Sonic 202111 release.

opencomputeproject/SAI@2e934ff

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 2, 2021

you can update SAI pointer in the same pr

@kperumalbfn
Copy link
Author

@kcudnik @rlhui Can we update Sonic's SAI refpoint to the latest one in SAI(v1.9.0-rc1)?

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 2, 2021

@lguohan can you response

Can we update Sonic's SAI refpoint to the latest one in SAI(v1.9.0-rc1)?

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 21, 2021

please fix conflicts

@kperumalbfn
Copy link
Author

@kcudnik I have updated SAI version to 1.9.0 and added changes to new modules ipsec and my_mac.

@kperumalbfn
Copy link
Author

please fix conflicts

Reports conflict in SAI submodule file. How do we resolve this?

@kperumalbfn
Copy link
Author

@kcudnik Any steps before updating the SAI submodule? Please let me know if there are any steps to be followed.

@kperumalbfn
Copy link
Author

@kcudnik closing this PR and opening a new one #937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants