Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 #937

Merged
merged 16 commits into from
Sep 24, 2021
Merged

Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 #937

merged 16 commits into from
Sep 24, 2021

Conversation

kperumalbfn
Copy link

@kperumalbfn kperumalbfn commented Sep 21, 2021 •
edited

  • Update SAI SEGMENTROUTE object to SAI SRV6 object
  • Serialize and deserialize APIs for SRV6 MY_SID_ENTRY object
  • SAI refpoint update to V1.9.0

@kperumalbfn kperumalbfn changed the title Srv6 sai 190 Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 Sep 21, 2021
@kperumalbfn kperumalbfn mentioned this pull request Sep 21, 2021
Open
@kperumalbfn
Copy link
Author

@kcudnik please check this PR for SAI refpoint update and other SRV6 changes.

kcudnik
kcudnik reviewed Sep 23, 2021
View reviewed changes
meta/Meta.cpp Outdated Show resolved Hide resolved
kcudnik
kcudnik reviewed Sep 23, 2021
View reviewed changes
meta/SaiSerialize.cpp Outdated Show resolved Hide resolved
kcudnik
kcudnik reviewed Sep 23, 2021
View reviewed changes
syncd/Syncd.cpp Outdated Show resolved Hide resolved
kcudnik
kcudnik requested changes Sep 23, 2021
View reviewed changes
unittest/meta/TestSaiSerialize.cpp Outdated Show resolved Hide resolved
unittest/vslib/test_sai_vs_srv6.cpp Outdated Show resolved Hide resolved
vslib/sai_vs_nexthopgroup.cpp Show resolved Hide resolved
@kperumalbfn
Copy link
Author

@kcudnik most of the comments are addressed. Please check.

@kperumalbfn
Copy link
Author

@rlhui @kcudnik All sanities are passing for Sonic SAI v1.9.0 upgrade. Could you approve and merge the changes?

@kcudnik kcudnik merged commit 921cf0b into sonic-net:master Sep 24, 2021
@kcudnik
Copy link
Collaborator

kcudnik commented Sep 25, 2021

@kperumalbfn you recently updated MetaKeyHasher.cpp file adding sid_entry support, pleas add unittests for that file under /sonic-sairedis/unittest/meta/TestMetaKeyHasher.cpp, there are examples in this file for other entries as well so you can copy cat that

@kperumalbfn
Copy link
Author

@kcudnik will add the UT in the next commit

@kcudnik
Copy link
Collaborator

kcudnik commented Sep 27, 2021

@kcudnik will add the UT in the next commit

Actually i already added them, but you can double check if i missed something

@kperumalbfn
Copy link
Author

Thanks @kcudnik

@hzheng5 hzheng5 mentioned this pull request Oct 21, 2021
Merged
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sonic sairedis changes for SAI SRV6 and SAI refpoint update to v1.9.0 (…
12de0b9 
…sonic-net#937)

Update SAI SEGMENTROUTE object to SAI SRV6 object
Serialize and deserialize APIs for SRV6 MY_SID_ENTRY object
SAI refpoint update to V1.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kperumalbfn @kcudnik