add remove queue port map function #1558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging e6c9ee6 into e1dd327 - view on LGTM.com new alerts:
|
|
@lguohan - pls help with review - thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added removeQueueMapPerPort() counter part of generateQueueMapPerPort()
Why I did it
Need this cleanup as part of port remove.
How I verified it
Verified the Queue counter map before and after port remove and create
Details if related
Used these command to verify the cleanup
redis-cli -n 2 hgetall COUNTERS_QUEUE_NAME_MAP > q_name_map.txt
redis-cli -n 2 hgetall COUNTERS_QUEUE_PORT_MAP > q_port_map.txt
redis-cli -n 2 hgetall COUNTERS_QUEUE_TYPE_MAP > q_type_map.txt
redis-cli -n 2 hgetall COUNTERS_QUEUE_INDEX_MAP > q_index_map.txt