[cli/feature]: split feature into a separate file #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
changed the title
|
will use similar approach to split other commands. |
This comment has been minimized.
This comment has been minimized.
FYI, this is a helpful start toward resolving #967! |
jleveque
suggested changes
Aug 7, 2020
jleveque
suggested changes
Aug 7, 2020
jleveque
previously approved these changes
Aug 8, 2020
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
|
@jleveque , rebased to latest master |
jleveque
approved these changes
Aug 8, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
- What I did
split feature into a separate file
- How I did it
create new feature.py for both config and show, move the code into feature.py
move common code into sonic-utiltities.common.cli.py
- How to verify it
unit test
also run it in vs switch
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)