Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "state" field in CONFIG_DB a toggle of the fabric port monitor feature #2932

Conversation

jfeng-arista
Copy link
Contributor

fabric port monitoring feature. The command to set this is "config fabric port monitor state <enable/disable>"

What I did

Add "state" field in CONFIG_DB fabric_monitor table as a toggle of the fabric port monitor feature.
The command is "config fabric port monitor state <enable/disable>"

Also add a test for this. The sonic mgmt test will be added shortly.

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@jfeng-arista
Copy link
Contributor Author

test_config_int_ip_rem_xxx tests failure, not related to this change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-utilities

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-utilities

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_config_int_ip_rem_xxx tests failure, do not look like related to this change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-utilities

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-utilities

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista jfeng-arista force-pushed the master-fabric-monitor-feature-toggle-command branch from 268e218 to 49427b2 Compare August 8, 2023 17:00
@jfeng-arista
Copy link
Contributor Author

test_config_int_ip_rem[ip_route_for_int_ip]
assert 1 == 0 +1 -0

test_config_int_ip_rem_static[ip_route_for_int_ip]
AssertionError: assert 'Error: Cannot remove the last IP entry of interface Ethernet2. A static ip route is still bound to the RIF.' in '' + where '' = <Result KeyError('namespace')>.output

the failures do not look like related to this change

@jfeng-arista jfeng-arista force-pushed the master-fabric-monitor-feature-toggle-command branch from 49427b2 to 91c7615 Compare August 14, 2023 16:33
@jfeng-arista
Copy link
Contributor Author

test_config_int_ip_rem[ip_route_for_int_ip]
assert 1 == 0 +1 -0
test_config_int_ip_rem_sub_intf[ip_route_for_int_ip]
assert 1 == 0 +1 -0

it failed with above tests, it does not look like related to this change.

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

config/fabric.py Outdated Show resolved Hide resolved
config/fabric.py Outdated Show resolved Hide resolved
config/fabric.py Show resolved Hide resolved
fabric port monitoring feature. The command to set this is "config
fabric port monitor state <enable/disable>"
fabric port monitoring feature. The command to set this is "config
fabric port monitor state <enable/disable>"

Signed-off-by: Jie Feng <jfeng@arista.com>
@jfeng-arista jfeng-arista force-pushed the master-fabric-monitor-feature-toggle-command branch 2 times, most recently from 6dbcb81 to 018770e Compare August 16, 2023 06:01
fabric port monitoring feature. The command to set this is "config
fabric port monitor state <enable/disable>"

Signed-off-by: Jie Feng <jfeng@arista.com>
@jfeng-arista jfeng-arista force-pushed the master-fabric-monitor-feature-toggle-command branch from 018770e to cac9fef Compare August 18, 2023 04:52
arlakshm
arlakshm previously approved these changes Dec 1, 2023
@arlakshm
Copy link
Contributor

arlakshm commented Dec 1, 2023

/Azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Contributor

@arlakshm could you review again

@judyjoseph
Copy link
Contributor

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-utilities

@vmittal-msft vmittal-msft self-requested a review March 21, 2024 22:30
@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vmittal-msft vmittal-msft merged commit 04a33e1 into sonic-net:master Mar 25, 2024
5 checks passed
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Apr 2, 2024
…ature (sonic-net#2932)

* Add "state" field in CONFIG_DB fabric_monitor table as a toggle of the
fabric port monitoring feature. The command to set this is "config
fabric port monitor state <enable/disable>"
---------
Signed-off-by: Jie Feng <jfeng@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants