Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fabric port monitoring toggle check #3132

Merged
merged 16 commits into from
May 30, 2024
Merged

Add fabric port monitoring toggle check #3132

merged 16 commits into from
May 30, 2024

Conversation

jfeng-arista
Copy link
Contributor

What I did
Add fabric port monitoring toggle check.
The command is added at sonic-net/sonic-utilities#2932. This is the orchagent handling part.

Why I did it

How I verified it

Details if related

@jfeng-arista jfeng-arista mentioned this pull request May 10, 2024
Merged
@rlhui rlhui added the P0 label May 15, 2024
@jfeng-arista
Copy link
Contributor Author

the failures look like not related to this change, I am starting again

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2).
<class 'AssertionError'>
LAG ID allocator table full error is not returned
assert '0' == '1'

not related to thsi change

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test_chassis_system_lag_id_allocator_table_full failed (1 runs remaining out of 2).
<class 'AssertionError'>
LAG ID allocator table full error is not returned
assert '0' == '1'

not related to this chagne

@jfeng-arista
Copy link
Contributor Author

the failure not related to this change, it is synced down .

@jfeng-arista
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-swss

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

test failures are from upstream, not related to this change

@prsunny prsunny merged commit c7ecd7d into sonic-net:master May 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmittal-msft vmittal-msft vmittal-msft left review comments

@arlakshm arlakshm arlakshm approved these changes

@abdosi abdosi Awaiting requested review from abdosi abdosi is a code owner

@judyjoseph judyjoseph Awaiting requested review from judyjoseph judyjoseph is a code owner

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees
No one assigned
Labels
chassis P0
Projects
SONiC Chassis
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jfeng-arista @mssonicbld @arlakshm @vmittal-msft @prsunny @rlhui @judyjoseph