Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVM Module Issue]: Key vault name validation incorrect #98

Closed
1 task done
captainhook opened this issue Apr 24, 2024 · 4 comments · Fixed by #113 or #125
Closed
1 task done

[AVM Module Issue]: Key vault name validation incorrect #98

captainhook opened this issue Apr 24, 2024 · 4 comments · Fixed by #113 or #125
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Type: Bug 🐛 Something isn't working

Comments

@captainhook
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

(Optional) Module Version

0.5.3

(Optional) Correlation Id

No response

Description

The current condition for key vault name is condition = can(regex("^[a-z0-9-]{3,24}$", var.name)) which is not in line with Microsoft's guidance.

As per official documentation

Entity Scope Length Valid Characters
... ... ... ...
vaults global 3-24 Alphanumerics and hyphens.
Start with letter. End with letter or digit. Can't contain consecutive hyphens.

source: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules
@captainhook captainhook added Language: Terraform 🌐 This is related to the Terraform IaC language Needs: Triage 🔍 Maintainers need to triage still labels Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Apr 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label May 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed label May 16, 2024
@matt-FFFFFF matt-FFFFFF removed Needs: Immediate Attention ‼️ Immediate attention of module owner / AVM team is needed Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days labels Jun 4, 2024
@matt-FFFFFF
Copy link
Member

This will be fixed in the next release

@matt-FFFFFF
Copy link
Member

fixed by #113

@matt-FFFFFF matt-FFFFFF linked a pull request Jun 10, 2024 that will close this issue
fix!: latest avm standards #113
Merged
11 tasks
@captainhook
Copy link
Author

captainhook commented Jul 2, 2024 •
edited
Loading

@matt-FFFFFF this is still incorrect.

Please re-open.

The correct restriction is:
"Alphanumerics and hyphens.
Start with letter. End with letter or digit. Can't contain consecutive hyphens."

However the current restriction only allows lowercase alphanumerics.

As per documentation: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftkeyvault

@matt-FFFFFF matt-FFFFFF mentioned this issue Jul 2, 2024
Merged
11 tasks
@matt-FFFFFF
Copy link
Member

Fixed in v0.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@matt-FFFFFF @captainhook