Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 Required Log Analytics Solutions for SQL Assessments for MDFC #387

Closed
jtracey93 opened this issue May 26, 2022 · 2 comments · Fixed by #396
Closed

Add 2 Required Log Analytics Solutions for SQL Assessments for MDFC #387

jtracey93 opened this issue May 26, 2022 · 2 comments · Fixed by #396
Labels
enhancement New feature or request PR-merged

Comments

@jtracey93
Copy link
Collaborator

jtracey93 commented May 26, 2022

See upstream issue Azure/Enterprise-Scale#979

Add 2 Required Log Analytics Solutions for SQL Assessments for MDFC.

Missing Solutions:

  • SQLVulnerabilityAssessment
  • SQLAdvancedThreatProtection
"product": "OMSGallery/SQLAdvancedThreatProtection",
"publisher": "Microsoft"

&

"product": "OMSGallery/SQLVulnerabilityAssessment",
"publisher": "Microsoft"
@jtracey93 jtracey93 added the enhancement New feature or request label May 26, 2022
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 26, 2022
@krowlandson
Copy link
Contributor

@jtracey93 Do you think these should be covered under the existing enable_solution_for_sql_assessment input variable, or need dedicated ones?

variable "configure_management_resources" {
type = object({
settings = object({
log_analytics = object({
enabled = bool
config = object({
retention_in_days = number
enable_monitoring_for_arc = bool
enable_monitoring_for_vm = bool
enable_monitoring_for_vmss = bool
enable_solution_for_agent_health_assessment = bool
enable_solution_for_anti_malware = bool
enable_solution_for_azure_activity = bool
enable_solution_for_change_tracking = bool
enable_solution_for_service_map = bool
enable_solution_for_sql_assessment = bool
enable_solution_for_updates = bool
enable_solution_for_vm_insights = bool
enable_sentinel = bool
})
})

@krowlandson krowlandson removed the Needs: Triage 🔍 Needs triaging by the team label May 31, 2022
@jtracey93
Copy link
Collaborator Author

@krowlandson whilst I agree they could fit under the enable_solution_for_sql_assessment input variable I think they should be separate in an effort to provide as much felxibility as possible, just in case someone needs to not have one of the solutions but does want the other.

TLDR: separate 👍

krowlandson pushed a commit to krowlandson/terraform-azurerm-caf-enterprise-scale that referenced this issue Jun 7, 2022
+ SQLVulnerabilityAssessment
+ SQLAdvancedThreatProtection
krowlandson pushed a commit to krowlandson/terraform-azurerm-caf-enterprise-scale that referenced this issue Jun 7, 2022
@krowlandson krowlandson mentioned this issue Jun 7, 2022
6 tasks
@ghost ghost added the PR-referenced label Jun 7, 2022
krowlandson pushed a commit that referenced this issue Jun 7, 2022
* Add SQL solutions to fix issue #387
+ SQLVulnerabilityAssessment
+ SQLAdvancedThreatProtection

* Add updates for #387 to Wiki

* Apply consistent format for notes in Wiki

* Add to upgrade guidance

* Prepare for release `v2.1.0`

* Add updates to baseline_values.json

Co-authored-by: github-actions <action@github.com>
@ghost ghost added PR-merged and removed PR-referenced labels Jun 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request PR-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants