Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated var and readme for windows vm example #96

Merged
merged 1 commit into from
Apr 3, 2019
Merged

updated var and readme for windows vm example #96

merged 1 commit into from
Apr 3, 2019

Conversation

AlexBevan
Copy link
Contributor

#87

@msftclas
Copy link

msftclas commented Mar 20, 2019 •
edited

CLA assistant check
All CLA requirements met.

@metacpp metacpp requested a review from JunyiYi April 3, 2019 00:44
metacpp
metacpp approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@metacpp metacpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexBevan Thanks for the contribution and it LGTM.

@metacpp metacpp merged commit dbe0daa into Azure:master Apr 3, 2019
AlexBevan added a commit to AlexBevan/terraform-azurerm-compute that referenced this pull request Oct 23, 2019
@AlexBevan
Merge branch 'master' of github.com:AlexBevan/terraform-azurerm-compute
3370999 
* 'master' of github.com:AlexBevan/terraform-azurerm-compute:
  Update module dependency on Random to allow use in Terraform 0.12.3 (Azure#108)
  bumb os version (Azure#94)
  updated var and readme for windows vm example (Azure#96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacpp metacpp metacpp approved these changes

@JunyiYi JunyiYi Awaiting requested review from JunyiYi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexBevan @msftclas @metacpp