Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pull request #41 so we can customize arguments for public ip. #54

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

lonegunmanb
Copy link
Member

Describe your changes

This pr added some new variables for azurerm_public_ip resource, basically it rewrite #41 since it was submitted more than 1 year ago.

Issue number

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests January 9, 2023 06:33 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests January 16, 2023 04:00 — with GitHub Actions Inactive
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants