Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azapi: Support client_certificate field #513

Merged
merged 4 commits into from
May 28, 2024
Merged

azapi: Support client_certificate field #513

merged 4 commits into from
May 28, 2024

Conversation

ms-henglu
Copy link
Collaborator

@ms-henglu ms-henglu commented May 23, 2024

related issue: #488

This PR also refactors the logics that build credentials and adds test cases for different authentication methods.

Test results:

  1. az cli
=== RUN   TestAccAuth_azcli
=== PAUSE TestAccAuth_azcli
=== CONT  TestAccAuth_azcli
--- PASS: TestAccAuth_azcli (39.17s)
PASS
  1. sp client secret
    running test....

  2. sp client certificate path

=== RUN   TestAccAuth_clientCertificatePath
=== PAUSE TestAccAuth_clientCertificatePath
=== CONT  TestAccAuth_clientCertificatePath
--- PASS: TestAccAuth_clientCertificatePath (38.29s)
PASS
  1. sp client certificate
=== RUN   TestAccAuth_clientCertificate
=== PAUSE TestAccAuth_clientCertificate
=== CONT  TestAccAuth_clientCertificate
--- PASS: TestAccAuth_clientCertificate (38.17s)
PASS

  1. oidc
image
  1. msi
adminuser@henglu-vm:~/terraform-provider-azapi$ TF_ACC=1 /snap/bin/go test -v ./internal/services -run TestAccActionDataSource_providerAction -timeout 10m -ldflags="-X=github.com/Azure/terraform-provider-azapi/version.ProviderVersion=acc"

=== RUN   TestAccActionDataSource_providerAction
=== PAUSE TestAccActionDataSource_providerAction
=== CONT  TestAccActionDataSource_providerAction
--- PASS: TestAccActionDataSource_providerAction (32.21s)
PASS
ok  	github.com/Azure/terraform-provider-azapi/internal/services	32.218s

@ms-henglu ms-henglu requested a review from magodo May 24, 2024 06:32
@ms-henglu ms-henglu merged commit 3cc6fd8 into main May 28, 2024
9 of 11 checks passed
@ms-henglu ms-henglu added this to the v1.14.0 milestone May 28, 2024
@ms-henglu ms-henglu deleted the issue-488 branch May 28, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants