replace tspNamespace with crossLanguageDefinitionId in enum, model, union and array types
#1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArcturusZhang
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar and
joheredi
as code owners
microsoft-github-policy-service
bot
added
the
lib:tcgc
weidongxu-microsoft
approved these changes
Jun 25, 2024
|
All changed packages have been documented.
Show changes
|
ArcturusZhang
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
tadelesh
approved these changes
Jun 25, 2024
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/1075/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/1075/ |
tadelesh
removed
the
lib:tcgc
…dd-crosslanguagedefinitionid
ArcturusZhang
deleted the
remove-tspnamespace-add-crosslanguagedefinitionid
branch
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1073
Per offline discussion,
crossLanguageDefinitionIdis actually a much better candidate of telling people the originate of this type, therefore this should solve all of our requirement and we no longer need atspNamespaceanymore.