Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating autorest to emit response headers in lexicographic order #414

Merged
merged 12 commits into from
Apr 2, 2024
Merged

updating autorest to emit response headers in lexicographic order #414

merged 12 commits into from
Apr 2, 2024

Conversation

allenjzhang
Copy link
Member

No description provided.

@allenjzhang allenjzhang linked an issue Mar 13, 2024 that may be closed by this pull request
Update typespec-autorest to put response headers in lexicographic order #409
Closed
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 13, 2024 •
edited
Loading

All changed packages have been documented.

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/typespec-azure/prs/414/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/typespec-azure/prs/414/

timotheeguerin
timotheeguerin reviewed Mar 14, 2024
View reviewed changes
packages/typespec-autorest/test/response-headers-order.test.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this test to sorting.test.ts

timotheeguerin
timotheeguerin approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit to make the test cleaner and more in line with the other sorting test. Wondering if we should not wait till the last miniute to merge that one so we don';t need to keep regenerating specs in teh spec repo

@timotheeguerin timotheeguerin added this to the [2024] April milestone Apr 1, 2024
@timotheeguerin timotheeguerin enabled auto-merge (squash) April 2, 2024 00:13
@timotheeguerin timotheeguerin merged commit 61468ad into Azure:main Apr 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
[2024] April
Development

Successfully merging this pull request may close these issues.

Update typespec-autorest to put response headers in lexicographic order
3 participants
@allenjzhang @azure-sdk @timotheeguerin