Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated node version to 20 as node 16 is deprecated #407

Merged
merged 10 commits into from
Apr 8, 2024
Merged

Updated node version to 20 as node 16 is deprecated #407

merged 10 commits into from
Apr 8, 2024

Conversation

ShilpiRachna1
Copy link
Collaborator

@ShilpiRachna1 ShilpiRachna1 commented Apr 2, 2024 •
edited
Loading

  • Updated node version to 20 as node 16 is deprecated
  • Updated versions of dependencies to fix build and test breaks. Current versions of Typescript and Jest are not compatible with node20
  • Updated node_modules auto-generated by running npm install

Validation done:

  • Validated the changes by running the tests in the repo
  • Verified the fix end to end by deploying some sample applications (for nodejs, python, php) with GitHub Actions from this branch.

@ShilpiRachna1 ShilpiRachna1 self-assigned this Apr 2, 2024
@surenderssm surenderssm mentioned this pull request Apr 2, 2024
Closed
kumaraksh1
kumaraksh1 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@kumaraksh1 kumaraksh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@ShilpiRachna1 ShilpiRachna1 merged commit 8e359a3 into releases/v2 Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraksh1 kumaraksh1 kumaraksh1 approved these changes

@surenderssm surenderssm Awaiting requested review from surenderssm

Assignees

@ShilpiRachna1 ShilpiRachna1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShilpiRachna1 @kumaraksh1 @ShilpiR