Support decryption using AesGcm #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
from
f2b7a2d
to
6e7f33e
Compare
mafurman
reviewed
Mar 4, 2021
mafurman
reviewed
Mar 4, 2021
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
from
0761e11
to
9ad3745
Compare
GeoK
reviewed
Mar 9, 2021
src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Mar 9, 2021
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
from
c028446
to
db230a1
Compare
|
SonarCloud Quality Gate failed. |
src/Microsoft.IdentityModel.Tokens/Encryption/AuthenticatedEncryptionProvider.cs
Show resolved
Hide resolved
|
I will write a stress test for this and post the results. |
GeoK
reviewed
Mar 23, 2021
src/Microsoft.IdentityModel.Tokens/Encryption/AuthenticatedEncryptionProvider.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Mar 23, 2021
src/Microsoft.IdentityModel.Tokens/Microsoft.IdentityModel.Tokens.csproj
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Apr 7, 2021
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Apr 7, 2021
GeoK
reviewed
Apr 7, 2021
test/Microsoft.IdentityModel.Tokens.Tests/AuthenticatedEncryptionProviderTests.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Apr 7, 2021
src/Microsoft.IdentityModel.Tokens/Encryption/AuthenticatedEncryptionProvider.cs
Outdated
Show resolved
Hide resolved
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
3 times, most recently
from
b60b693
to
eb99228
Compare
GeoK
reviewed
Apr 15, 2021
| @@ -88,6 +87,44 @@ public override string ToString() | |||
| /// </summary> | |||
| public class AuthenticatedEncryptionProviderTests | |||
| { | |||
| #if NET_CORE | |||
There was a problem hiding this comment.
nit: you could merge these two tests together and use
[PlatformSpecific(TestPlatforms.OSX | TestPlatforms.Linux)]
|
/azp run |
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
from
eb99228
to
19731f2
Compare
RojaEnnam
force-pushed
the
roennam/AesGcmProvider
branch
from
19731f2
to
5008f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes AesGcm decryption implementation using Bcrypt library and reference test from the spec.