First Round of Trimming Analysis

[eerhardt]

This enables trimming analysis on a subset of core assemblies:

• Microsoft.IdentityModel.Abstractions
• Microsoft.IdentityModel.Logging

It also enables trimming analysis for the JsonWebToken constructor. More scenarios will be analyzed in the future, as we enable more scenarios for trimming.

Contributes to #2035

See https://learn.microsoft.com/dotnet/core/deploying/trimming/prepare-libraries-for-trimming for more information on how to prepare libraries for trimming. Being "trim compatible" is the first step to being "NativeAOT compatible".

This addresses the first bullet in #2035.

cc @brentschmaltz

[brentschmaltz]

@eerhardt i cloned your repo and running build.cmd from a cmd prompt resulted in a build failure.

Cloned to:
C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\

sample of the errors:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Roslyn\Microsoft.Managed.Core.targets(190,5): error : Could not find a part of the path 'C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\obj\Debug\net452\Microsoft.Identit
yModel.ManagedKeyVaultSecurityKey.Tests.GeneratedMSBuildEditorConfig.editorconfig'. [C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests.csproj::TargetFramework=net452]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Roslyn\Microsoft.Managed.Core.targets(190,5): error : Could not find a part of the path 'C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\obj\Debug\net461\Microsoft.Identit
yModel.ManagedKeyVaultSecurityKey.Tests.GeneratedMSBuildEditorConfig.editorconfig'. [C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests.csproj::TargetFramework=net461]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Roslyn\Microsoft.Managed.Core.targets(190,5): error : Could not find a part of the path 'C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\obj\Debug\net472\Microsoft.Identit
yModel.ManagedKeyVaultSecurityKey.Tests.GeneratedMSBuildEditorConfig.editorconfig'. [C:\github\wilson\eehardt\azure-activedirectory-identitymodel-extensions-for-dotnet\test\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests\Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests.csproj::TargetFramework=net472]

[eerhardt]

Thanks, looking.

BTW - is there PR validation hooked up in this repo? I don't see a "check" for building and running tests. Some PRs have the checks for "Wilson-6x-PR" and some don't.

Has checks:

• Xiao/LKG configuration cache #2007
• Add encryption keys to base configuration #2023

No Checks:

• this one
• Update XML documentation of JsonWebTokenHandler.CreateToken(SecurityTokenDescriptor tokenDescriptor) #2009
• Make time related validation related error messages more user-friendly #2012

[eerhardt]

i cloned your repo and running build.cmd from a cmd prompt resulted in a build failure.

@brentschmaltz I'm not seeing this build error locally. Does it repro if you git clean -xdff and build again? Does the dev branch build cleanly on that machine?

I didn't change Microsoft.IdentityModel.ManagedKeyVaultSecurityKey.Tests, or any build infrastructure, so I'm confused why those errors would be occurring in just my PR.

I did notice that I need to update buildConfiguration.xml to include my new test project though. I'll push that change up.

[eerhardt]

I plan on moving this to the main repo in order to get PR validation tests to run against this change. I am just waiting for permission to do that.

In the meantime - cc @vitek-karas in case you want to take a look.

[eerhardt]

Closing in favor of #2042.