Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditional compilation for net 8 #2122

Merged
merged 1 commit into from Jun 27, 2023
Merged

conditional compilation for net 8 #2122

merged 1 commit into from Jun 27, 2023

Conversation

westin-m
Copy link
Contributor

@westin-m westin-m commented Jun 26, 2023 •
edited

opt in for targeting net 8 through env variable

@westin-m westin-m linked an issue Jun 26, 2023 that may be closed by this pull request
[Feature Request] Conditional compilation for net8.0 #2111
Closed
jennyf19
jennyf19 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM....will you do something similar in Id Web?

jmprieur
jmprieur approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @westin-m
I checked, this build on a machine where .NET 8 is not installed!

build/common.props Outdated Show resolved Hide resolved
@westin-m westin-m force-pushed the westinm/net8conditionCompile branch from 111aa76 to 66d215c Compare June 27, 2023 17:54
@westin-m westin-m merged commit 252ca4e into dev7x Jun 27, 2023
1 check passed
@westin-m westin-m deleted the westinm/net8conditionCompile branch June 27, 2023 17:55
brentschmaltz pushed a commit that referenced this pull request Jul 25, 2023
@westin-m
Compile .net 8 based on environment variable (#2122)
56474d1
brentschmaltz pushed a commit that referenced this pull request Jul 28, 2023
@westin-m
Compile .net 8 based on environment variable (#2122)
d7fb143
brentschmaltz pushed a commit that referenced this pull request Sep 6, 2023
@westin-m
Compile .net 8 based on environment variable (#2122)
f4c2204
brentschmaltz pushed a commit that referenced this pull request Sep 7, 2023
@westin-m @brentschmaltz
Compile .net 8 based on environment variable (#2122)
7f818c2
@jennyf19 jennyf19 mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

@brentschmaltz brentschmaltz Awaiting requested review from brentschmaltz

@keegan-caruso keegan-caruso Awaiting requested review from keegan-caruso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Conditional compilation for net8.0
4 participants
@westin-m @jmprieur @jennyf19 @keegan-caruso