Initial addition of Nullable property to Abstractions Project. #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuPingFranco
requested review from
jmprieur,
jennyf19,
westin-m and
victorm-hernandez
jmprieur
reviewed
Jul 12, 2023
westin-m
reviewed
Jul 12, 2023
jmprieur
reviewed
Jul 12, 2023
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
jennyf19
reviewed
Jul 13, 2023
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/GlobalSuppressions.cs
Show resolved
Hide resolved
jmprieur
approved these changes
Jul 18, 2023
keegan-caruso
approved these changes
Jul 25, 2023
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
brentschmaltz
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
brentschmaltz
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR to Abstractions project to enable nullable across the solution allowing variables to have null as a value, which can be useful in cases where a value may not be present or when a value is optional. It also allows for the use of null-forgiving operator, which suppresses nullable warnings for an expression.