The first step in replacing newtonsoft with System.Text.Json #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Jul 26, 2023
eerhardt
reviewed
Jul 26, 2023
test/Microsoft.IdentityModel.JsonWebTokens.Tests/Properties/AssemblyInfo.cs
Show resolved
Hide resolved
westin-m
approved these changes
Jul 26, 2023
brentschmaltz
force-pushed
the
brentsch/TestsUsingExternalNewtonsoft
branch
from
497976d
to
a8d6c97
Compare
Removed deprecated tests Removed internal newtonsoft
brentschmaltz
force-pushed
the
brentsch/TestsUsingExternalNewtonsoft
branch
from
a8d6c97
to
0d72d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed our internal newtonsoft, all our code uses the public newtonsoft.
This will ease the work to use System.Json.Text on a class-by-class basis.
The use of newtonsoft will be removed in all src code when we ship, but may remain in test code.
Removed tests that were designed to ensure that changes from 4.x -> 5.x where switched from System.IdentityModel.Tokens to Microsoft.IdentityModel.Tokens were not breaking, we do not need this code anymore.
Removed some old performance code that was moved to its own repo.
Cleaned up 'usings'.
Set CLSCompliant to false in all test code (Assemblyinfo.cs) so #ifdef's could be removed in code.