Change Task to ValueTask. #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you want to go this route we have to revert these changes as well: |
brentschmaltz
force-pushed
the
brentsch/ValueTask7
branch
2 times, most recently
from
ba7d1b8
to
6d4659a
Compare
|
@keegan-caruso you make a good point, it will be easier to make a single change in AadIssuerValidator. |
brentschmaltz
force-pushed
the
brentsch/ValueTask7
branch
from
6d4659a
to
54ba505
Compare
brentschmaltz
changed the title
|
Is it a breaking change for SAL? IdWeb? |
westin-m
approved these changes
Sep 5, 2023
jennyf19
approved these changes
Sep 5, 2023
brentschmaltz
added a commit
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
brentschmaltz
added a commit
that referenced
this pull request
Sep 7, 2023
Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
This was referenced Sep 11, 2023
Closed
This was referenced Jan 17, 2024
Open
Open
This was referenced Jan 25, 2024
Open
Bump System.IdentityModel.Tokens.Jwt from 6.31.0 to 6.34.0 in /PCAxis.Api
statisticssweden/PxWeb#611
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will have to coordinate this with other changes as Task is expected in some call graphs.