This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
allow teamid to be accessible #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrik-me
reviewed
Oct 12, 2018
| @@ -85,7 +85,8 @@ private string GetTeamId() | |||
| var queryRecord = new SecRecord(SecKind.GenericPassword) | |||
| { | |||
| Service = "", | |||
| Account = TeamIdKey | |||
| Account = TeamIdKey, | |||
| Accessible = SecAccessible.Always | |||
There was a problem hiding this comment.
Always [](start = 43, length = 6)
I would suggest we use: _defaultAccessiblityPolicy, as that is what we use for everything else. not sure we need more than that. However Olga knows best!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MSAL.NET #626: PublicClientApplication constructor throws exception when iPhone screen is locked
According to olga, the TeamId can be accessible always as there is no private info in it. This is to access TeamId when the phone is locked.