Skip to content
This repository has been archived by the owner on Jun 30, 2023. It is now read-only.

change logs for next release #1389

Merged
merged 3 commits into from
Nov 7, 2018
Merged

change logs for next release #1389

merged 3 commits into from
Nov 7, 2018

Conversation

jennyf19
Copy link
Contributor

@jennyf19 jennyf19 commented Nov 7, 2018

I tried to get everything, especially customer facing stuff, but we've had a lot of changes.

- Fix for internal TokenCache.Clear api so ADAL persistent cache is also cleared [MSAL Issue #651](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/651)
- Optimize cache lookups with native iOS by modifying field for persistence on iOS. [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350)
- Fix for reading ExtraQueryParameter environment variable on netcore in ADAL [ADAL issue #1362](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/issues/1362)
- Make a ConfidentialClient entry point obsolete on platforms which only support confidential clients [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1375)
Copy link
Contributor

@henrik-me henrik-me Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • [](start = 0, length = 2)

Cache fixes and this one should have the same indentation method, imo (consider matching with the MSAL changelog, that means a missing hyphen for Cache fixes) #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good.


In reply to: 231366029 [](ancestors = 231366029)

Copy link
Contributor

@jmprieur jmprieur Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose:
Version 4.4.0

Improvements and fixes to the token cache

  • The serialized token cache can now be shared by different applications, therefore providing SSO if the same user signs-in in both applications
  • On .NET Core, the Token cache was shared by all instances of applications in memory. This is now fixed (See MSAL.NET issue Added run settings file to exclude test projects from code coverage #656 and PR)
  • Fixes consistency issues for advanced token cache migration scenarios from ADAL v3.x to ADA v4.x to MSAL v2.x
  • Cache lookups were optimized. Work done in conjunction with ADAL.iOS and MSAL.iOS native) PR
  • The ExtraQueryParameter environment variable is now read on ADAL for the .NET Core platform, as was already the case in the .NET Framework case ADAL issue #1362
  • A Client credential API which should not be used on Xamarin.iOS, Xamarin.Android and UWP is now marked as obsolete
    • PR
      #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect...thank you.


In reply to: 231409302 [](ancestors = 231409302)

- Optimize cache lookups with native iOS by modifying field for persistence on iOS. [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350)
- Support [extended lifetime tokens](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1331)
- Remove Chrome dependency for system browser on Android devices. See https://aka.ms/msal-net-system-browsers for more information. [MSAL issue #664](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/664)
- Add support for b2clogin.com for b2c authorities [MSAL issue #669](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/669) [#632](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/632)
Copy link
Contributor

@henrik-me henrik-me Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add support for b2clogin.com for b2c authoritie [](start = 2, length = 47)

:) #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:face_with_rolling_eyes:


In reply to: 231366199 [](ancestors = 231366199)

- Fix for internal TokenCache.Clear api so ADAL persistent cache is also cleared [MSAL Issue #651](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/651)
- Optimize cache lookups with native iOS by modifying field for persistence on iOS. [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350)
- Support [extended lifetime tokens](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1331)
- Remove Chrome dependency for system browser on Android devices. See https://aka.ms/msal-net-system-browsers for more information. [MSAL issue #664](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/664)
Copy link
Contributor

@henrik-me henrik-me Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Chrome dependency for system browser [](start = 2, length = 43)

:) #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:face_with_rolling_eyes:


In reply to: 231366239 [](ancestors = 231366239)

Copy link
Contributor

@jmprieur jmprieur Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose:
2.4.0-preview

Improvements and fixes to the token cache

More browsers are now supported on Xamarin.Android when you choose to use system web browsers.

Azure AD B2C improvement

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great...thank you. we needed your PM magic. I did a copy/paste


In reply to: 231409353 [](ancestors = 231409353)

Copy link
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but proposed improvements :)

- Fix for internal TokenCache.Clear api so ADAL persistent cache is also cleared [MSAL Issue #651](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/651)
- Optimize cache lookups with native iOS by modifying field for persistence on iOS. [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350)
- Fix for reading ExtraQueryParameter environment variable on netcore in ADAL [ADAL issue #1362](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/issues/1362)
- Make a ConfidentialClient entry point obsolete on platforms which only support confidential clients [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1375)
Copy link
Contributor

@jmprieur jmprieur Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose:
Version 4.4.0

Improvements and fixes to the token cache

  • The serialized token cache can now be shared by different applications, therefore providing SSO if the same user signs-in in both applications
  • On .NET Core, the Token cache was shared by all instances of applications in memory. This is now fixed (See MSAL.NET issue Added run settings file to exclude test projects from code coverage #656 and PR)
  • Fixes consistency issues for advanced token cache migration scenarios from ADAL v3.x to ADA v4.x to MSAL v2.x
  • Cache lookups were optimized. Work done in conjunction with ADAL.iOS and MSAL.iOS native) PR
  • The ExtraQueryParameter environment variable is now read on ADAL for the .NET Core platform, as was already the case in the .NET Framework case ADAL issue #1362
  • A Client credential API which should not be used on Xamarin.iOS, Xamarin.Android and UWP is now marked as obsolete
    • PR
      #Resolved

- Fix for internal TokenCache.Clear api so ADAL persistent cache is also cleared [MSAL Issue #651](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/651)
- Optimize cache lookups with native iOS by modifying field for persistence on iOS. [PR](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1350)
- Support [extended lifetime tokens](https://github.com/AzureAD/azure-activedirectory-library-for-dotnet/pull/1331)
- Remove Chrome dependency for system browser on Android devices. See https://aka.ms/msal-net-system-browsers for more information. [MSAL issue #664](https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/664)
Copy link
Contributor

@jmprieur jmprieur Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose:
2.4.0-preview

Improvements and fixes to the token cache

More browsers are now supported on Xamarin.Android when you choose to use system web browsers.

Azure AD B2C improvement

@jennyf19 jennyf19 merged commit 2ecbac9 into dev Nov 7, 2018
@jennyf19 jennyf19 deleted the jennyf/changelog4.4 branch November 8, 2018 03:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants