Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Draft: Add interactive auth #73

Closed

Conversation

olivierdagenais
Copy link

@lenala and I have been looking at rewriting the work that was originally submitted as pull request #20.

We think we found a way to lighten the dependency requirements for adding the interactive authentication feature through using the oauth2-useragent library. Specifically, this component removes the need for a web server and for needing SWT at compile-time. It currently uses JavaFX to launch a web browser on platforms that support it (Oracle Java 7 Update 6 & up, and Oracle Java 8) and eventually will add SWT support for platforms that don't support JavaFX, but the SWT dependencies would be the responsibility of program builders, which they could pass on to end-users. The point is, with this approach, SWT won't be added to ADAL4J's dependencies, reducing the impact for non-interactive consumers/users.

This PR is currently a rough outline of the proposed changes. Before we go any further with the implementation, we wanted to run it by your team. Commit ba085fa is where most of the proposed changes lie, in the form of TODOs. There are a few open questions as to the best/most elegant way to approach/implement this (specifically the use of the proposed InteractiveAuthorizationGrant so we can re-use the private acquireToken() helper method, when should the UserAgent implementation be created and so on), so your feedback would be greatly appreciated.

Please let us know how we can best be successful at adding interactive authentication & authorization so that it can land in, say, version 1.2 of ADAL4J.

Thanks!

Oli Dagenais added 5 commits December 8, 2015 16:16
I added REFRESH_SESSION even though it won't be implemented just yet.
This will make it easier to add other special cases.
There are a few open questions for discussion.
@msftclas
Copy link

msftclas commented Dec 9, 2015

Hi @olivierdagenais, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Oli Dagenais). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@kpanwar
Copy link
Contributor

kpanwar commented Mar 12, 2017

closing because Olivier is no longer with MSFT.

@kpanwar kpanwar closed this Mar 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants