This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lenala and I have been looking at rewriting the work that was originally submitted as pull request #20.
We think we found a way to lighten the dependency requirements for adding the interactive authentication feature through using the oauth2-useragent library. Specifically, this component removes the need for a web server and for needing SWT at compile-time. It currently uses JavaFX to launch a web browser on platforms that support it (Oracle Java 7 Update 6 & up, and Oracle Java 8) and eventually will add SWT support for platforms that don't support JavaFX, but the SWT dependencies would be the responsibility of program builders, which they could pass on to end-users. The point is, with this approach, SWT won't be added to ADAL4J's dependencies, reducing the impact for non-interactive consumers/users.
This PR is currently a rough outline of the proposed changes. Before we go any further with the implementation, we wanted to run it by your team. Commit ba085fa is where most of the proposed changes lie, in the form of TODOs. There are a few open questions as to the best/most elegant way to approach/implement this (specifically the use of the proposed
InteractiveAuthorizationGrant
so we can re-use the privateacquireToken()
helper method, when should theUserAgent
implementation be created and so on), so your feedback would be greatly appreciated.Please let us know how we can best be successful at adding interactive authentication & authorization so that it can land in, say, version 1.2 of ADAL4J.
Thanks!