This repository has been archived by the owner on Jun 26, 2021. It is now read-only.
fix: strict mode nested function adal-angular #820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions are declared in a nested conditional block.
|
|
|
UglifyJS also renders an error due to these nested functions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the adal-angular library within PhantomJS and strict mode (and in my case Chisel Web Accessibility tool), it throws an error keeping the AngularJS app from running. Moving in the function declaration to an inline call fixes this.
Tests
Unfortunately, there is no way to test this from what I can tell. If you think you can, please let me know and I'll update.