This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
Fix for cache entry leak #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 22, 2017 10:05
|
|
|
This fixes a similar problem we see using device login. 👍 |
milkeinstein
approved these changes
Dec 17, 2018
|
Is there any plans of merged/shipped in the near future? The error involving this fix still occurs very frequently. |
|
We are moving the code for ADAL Node to the MSAL.js repo. If you would still like this PR to be considered, please reopen it in the MSAL.js repo: https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/maintenance/adal-node Futhermore, we highly recommend upgrading to MSAL Node: https://www.npmjs.com/package/@azure/msal-node |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #139
Please double check that the list of cache-keys is complete and let me know If i need to add any.