Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Exceptions from internal API calls except for completionBlock #63

Closed
RPangrle opened this issue Apr 8, 2014 · 4 comments
Closed
Assignees
Labels

Comments

@RPangrle
Copy link
Contributor

RPangrle commented Apr 8, 2014

For internal errors they should report back errors using NSError objects either passed in as a method parameter or in a completionBlock callback. The one exception to this is when no completion block is provided.

@RandalliLama
Copy link
Contributor

@RPangrle-MS, did this get addressed?

@kpanwar
Copy link

kpanwar commented Oct 16, 2014

Currently, we throw exceptions only on invalid inputs like nil callbacks, resource and client id.

@RandalliLama
Copy link
Contributor

@kpanwar, per @RPangrle-MS, we should not be throwing exceptions anywhere. I think that it is acceptable to put Asserts in places where argument checking should obviously occurred higher in the stack.

@kpanwar
Copy link

kpanwar commented Nov 8, 2014

The feature work was completed in OSX branch and also merged in to DEV/MASTER.

@kpanwar kpanwar closed this as completed Nov 8, 2014
jasoncoolmax pushed a commit that referenced this issue Sep 6, 2016
Set ADAL submodule to iOS 10 Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants