Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to MSAL 1.27+'s TokenCache._find() #128

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Switch to MSAL 1.27+'s TokenCache._find() #128

merged 1 commit into from
Apr 15, 2024

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Apr 12, 2024

This PR will fix #127 . The fix will be shipped as MSALEX 1.2.0a1 within this month. And then next month both MSAL and MSAL EX will rename the affected function from _find() to iter().

CC @jiasli

@jiasli
Copy link
Contributor

jiasli commented Apr 12, 2024

And then next month both MSAL and MSAL EX will rename the affected function from _find() to iter()

You may choose other names as well. This is just an idea that pops up in my mind.

@bgavrilMS
Copy link
Member

@rayluo - how to avoid this type of regression in the future? Would it make sense to move the logic in this repo to the main MSAL repo? (we have done this in MSAL Java and MSAL .NET already - it also reduces the number of builds we need to look at).

@rayluo
Copy link
Contributor Author

rayluo commented Apr 12, 2024

@rayluo - how to avoid this type of regression in the future? Would it make sense to move the logic in this repo to the main MSAL repo? (we have done this in MSAL Java and MSAL .NET already - it also reduces the number of builds we need to look at).

I'm afraid merging repo would not be a good option for Python. Nowadays, all interop layers of Python (such as the PyMsalRuntime package) would ideally be implemented with different technology which requires different pipelines anyway. Might as well leave them in a self-contained, separated repo.

Good news is we have lighter weight approach to guard this. Previously I did not anticipate API-level change in token cache (which never happened in the last 5+ years), so I did not setup nightly builds to test it with MSAL's dev branch. My bad. We shall do it this time, and it shall be sufficient.

@rayluo rayluo merged commit ae07f28 into dev Apr 15, 2024
60 checks passed
@rayluo rayluo deleted the adopt-msal-1.27 branch April 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] msal_extensions.token_cache.PersistedTokenCache is bypassed by ConfidentialClientApplication
3 participants