Release 0.2.3 #72
Closed
Release 0.2.3 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MSAL Extensions for Python 0.2.2 back to dev branch
Add CodeQL Analysis workflow
Move .github/workflows/workflows dir to .github/workflows
Handle file not found exceptions on Python 2.7
* Unified exception when load() is called before save() * Go with an explicit PersistenceNotFound exception * Caller has a much simpler pattern to handle read errors * Change "where" to "location" * Test cases for PersistentNotFound
Change PersistenceNotFound's base from OSError to IOError
Bumping version number
rayluo
requested changes
Sep 1, 2020
| if data is None: | ||
| # Lower level libsecret would return None when found nothing. Here | ||
| # in persistence layer, we convert it to a unified error for consistence. | ||
| raise PersistenceNotFound(message=( |
There was a problem hiding this comment.
My bad. Although all other new PersistenceNotFound are not considered as breaking change, this particular one is. https://github.com/AzureAD/microsoft-authentication-extensions-for-python/pull/67/files#diff-3ef6fda259d01e5bd78b0a594e5f9f01R263-R264
Please abandon the 0.2.3 and let's go with 0.3.0
|
Closing this PR as we decided to do a 0.3.0 release instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersistenceNotFoundexception is now raised for cases where the persistence is not found. (Investigate OS errors returned for encryption scenarios on Windows and MacOS #64, Unified exception when load() is called before save() #67)