Move Broker encryption logic to broker code. Some more refactoring. #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamgusain
reviewed
Apr 20, 2023
common4j/src/main/com/microsoft/identity/common/java/crypto/StorageEncryptionManager.java
Show resolved
Hide resolved
iamgusain
reviewed
Apr 20, 2023
...c/main/java/com/microsoft/identity/common/crypto/AndroidAuthSdkStorageEncryptionManager.java
Outdated
Show resolved
Hide resolved
iamgusain
reviewed
Apr 20, 2023
...c/main/java/com/microsoft/identity/common/crypto/AndroidAuthSdkStorageEncryptionManager.java
Outdated
Show resolved
Hide resolved
iamgusain
reviewed
Apr 20, 2023
common/src/main/java/com/microsoft/identity/common/crypto/AndroidWrappedKeyLoader.java
Show resolved
Hide resolved
iamgusain
reviewed
Apr 20, 2023
common/src/main/java/com/microsoft/identity/common/crypto/AndroidWrappedKeyLoader.java
Outdated
Show resolved
Hide resolved
iamgusain
reviewed
Apr 20, 2023
...on/src/main/java/com/microsoft/identity/common/internal/controllers/LocalMSALController.java
Show resolved
Hide resolved
|
Let's also verify if this change would break oneauth |
iamgusain
approved these changes
Apr 21, 2023
fadidurah
approved these changes
Apr 24, 2023
rpdome
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://github.com/AzureAD/ad-accounts-for-android/pull/2241
Changes
Move
AndroidBrokerStorageEncryptionManagerand its tests to Broker (AndroidBrokerStorageEncryptionManagerWithLegacyKeyTest)Remove ITelemetryCallback usage. We don't need it anymore.
Kill AndroidPlatformComponents. We don't use it anymore.