Skip to content

Commit

Permalink
Fix warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
pmaytak committed Aug 3, 2023
1 parent 468a049 commit 63b2750
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public bool IsBrokerAvailable()
}

/// <inheritdoc cref="IPublicClientApplication.AcquireTokenInteractive(IEnumerable{string})"/>
[CLSCompliant(false)]
[CLSCompliant(false)]
public AcquireTokenInteractiveParameterBuilder AcquireTokenInteractive(
IEnumerable<string> scopes)
{
Expand All @@ -109,6 +109,7 @@ public bool IsBrokerAvailable()
.WithParentActivityOrWindowFunc(ServiceBundle.Config.ParentActivityOrWindowFunc);
}

/// <inheritdoc/>
public AcquireTokenWithDeviceCodeParameterBuilder AcquireTokenWithDeviceCode(
IEnumerable<string> scopes,
Func<DeviceCodeResult, Task> deviceCodeResultCallback)
Expand All @@ -119,6 +120,7 @@ public bool IsBrokerAvailable()
deviceCodeResultCallback);
}

/// <inheritdoc/>
AcquireTokenByRefreshTokenParameterBuilder IByRefreshToken.AcquireTokenByRefreshToken(
IEnumerable<string> scopes,
string refreshToken)
Expand All @@ -129,14 +131,16 @@ public bool IsBrokerAvailable()
refreshToken);
}

/// <inheritdoc/>
public AcquireTokenByIntegratedWindowsAuthParameterBuilder AcquireTokenByIntegratedWindowsAuth(
IEnumerable<string> scopes)
{
return AcquireTokenByIntegratedWindowsAuthParameterBuilder.Create(
ClientExecutorFactory.CreatePublicClientExecutor(this),
scopes);
}


/// <inheritdoc/>
[Obsolete("Using SecureString is not recommended. Use AcquireTokenByUsernamePassword(IEnumerable<string> scopes, string username, string password) instead.", false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public AcquireTokenByUsernamePasswordParameterBuilder AcquireTokenByUsernamePassword(
Expand All @@ -151,6 +155,7 @@ public bool IsBrokerAvailable()
new string(password.PasswordToCharArray()));
}

/// <inheritdoc/>
public AcquireTokenByUsernamePasswordParameterBuilder AcquireTokenByUsernamePassword(
IEnumerable<string> scopes,
string username,
Expand Down

1 comment on commit 63b2750

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'BenchmarkDotNet Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 0.01.

Benchmark suite Current: 63b2750 Previous: 468a049 Ratio
Microsoft.Identity.Test.Performance.AcquireTokenNoCacheTests.AcquireTokenForClient_TestAsync 480817.72 ns (± 19095.86719155616) 426552.0481927711 ns (± 43972.8743778074) 1.13
Microsoft.Identity.Test.Performance.AcquireTokenNoCacheTests.AcquireTokenOnBehalfOf_TestAsync 653815.5151515151 ns (± 16952.92949080116) 553827.7777777778 ns (± 15344.362641432679) 1.18

This comment was automatically generated by workflow using github-action-benchmark.

CC: @pmaytak

Please sign in to comment.