Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ClientCredential to internal #1007

Closed
MarkZuber opened this issue Mar 23, 2019 · 2 comments
Closed

Move ClientCredential to internal #1007

MarkZuber opened this issue Mar 23, 2019 · 2 comments
Assignees
@MarkZuber
Milestone
3.0.3

Comments

@MarkZuber
Copy link
Contributor

There is no longer a need for the ClientCredential class to be public. We can do one of the following:

  • Obsolete the class (so we can mark it [Obsolete]) and create a new ClientCredentialInternal class which is internal in order to replace the functionality
  • Move the class to internal (makes it harder for Obsolete / Migration notes)
@MarkZuber MarkZuber added this to the 3.0.2 milestone Mar 23, 2019
@MarkZuber MarkZuber changed the title Move ClientCredential internal Move ClientCredential to internal Mar 23, 2019
@jmprieur
Copy link
Contributor

I would prefer the first option to help the migration

@MarkZuber MarkZuber self-assigned this Mar 25, 2019
@jennyf19
Copy link
Collaborator

jennyf19 commented Apr 8, 2019

included in msal 3.0.3-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkZuber MarkZuber

Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

No branches or pull requests
3 participants
@MarkZuber @jmprieur @jennyf19