Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetAuthorizationRequestUrl ExecuteAsync with no cancellation token has bad signature #1193

Closed
bgavrilMS opened this issue Jun 3, 2019 · 4 comments
Labels
Milestone

Comments

@bgavrilMS
Copy link
Member

Which Version of MSAL are you using ?
3.0.8

Platform
all Confidential CLient

What authentication flow has the issue?
GetAuthorizationRequestUrl

Other? - please describe;

Repro

// This works
            Uri url = await cca.GetAuthorizationRequestUrl(scopes)
                 .ExecuteAsync(CancellationToken.None);

// This fails to compile
       Uri url = await cca.GetAuthorizationRequestUrl(scopes)
                 .ExecuteAsync();

Expected behavior
ExecuteAsync on this object should return an Uri on both overloads (ExecuteAsync() and ExecuteAsync(CancellationToken)

Actual behavior
ExecuteAsync() returns an AuthenticationRequest

@bgavrilMS bgavrilMS added the bug label Jun 3, 2019
@bgavrilMS bgavrilMS changed the title GetAuthorizationRequestUrl with no cancellation token has bad signature GetAuthorizationRequestUrl ExecuteAsync with no cancellation token has bad signature Jun 3, 2019
@bgavrilMS
Copy link
Member Author

@jmprieur @henrik-me - fix is trivial, propose we take it for 4.0.0 or 4.0.1

@jmprieur
Copy link
Contributor

jmprieur commented Jun 3, 2019

Go ahead. This is a breaking change (even if the previous one was useless)
BTW, this issue is a duplicate of #1184 ?

@jmprieur jmprieur added this to the 4.0 milestone Jun 3, 2019
@bgavrilMS
Copy link
Member Author

Ah yes, yes it is.

@bgavrilMS
Copy link
Member Author

Duplicate of #1184

@bgavrilMS bgavrilMS marked this as a duplicate of #1184 Jun 3, 2019
@bgavrilMS bgavrilMS added this to Done in MSAL.NET (legacy) via automation Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants