Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] MSAL last request telemetry only captures MsalServiceException #3547

Closed
bgavrilMS opened this issue Aug 2, 2022 · 0 comments · Fixed by #3621
Closed

[Bug] MSAL last request telemetry only captures MsalServiceException #3547

bgavrilMS opened this issue Aug 2, 2022 · 0 comments · Fixed by #3621
Assignees
@neha-bhargava
Labels
Feature Request ICM This issue has a corresponding ICM, either for our team or another.
Milestone
4.46.2

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Aug 2, 2022 •
edited by neha-bhargava

MSAL 4.46

We are missing exceptions which are not derived from MsalExceptions, in particular all the HttpExceptions.

Exceptions to be logged:
TaskCancelledException
Crypto Exception
@bgavrilMS bgavrilMS added this to the 4.47.0 milestone Aug 2, 2022
@bgavrilMS bgavrilMS added Feature Request ICM This issue has a corresponding ICM, either for our team or another. and removed bug P2 labels Aug 2, 2022
@pmaytak pmaytak mentioned this issue Aug 9, 2022
Closed
7 tasks
@neha-bhargava neha-bhargava self-assigned this Aug 12, 2022
@neha-bhargava neha-bhargava mentioned this issue Aug 22, 2022
Merged
@neha-bhargava neha-bhargava linked a pull request Aug 22, 2022 that will close this issue
Log exceptions to telemetry #3621
Merged
gladjohn added a commit that referenced this issue Aug 26, 2022
@gladjohn
Updated Changelog for MSAL 4.46.2
349c38d 
Updated Changelog for MSAL 4.46.2

[Feature Request] WAM Authentication Library Should Support .NET 4.5 for Back Compatibility [See 3539](#3539)
Log exceptions which are not converted to MsalExceptions to telemetry. [See #3547](#3547)

[Bug]Authenticator Factory has already been started. [See #3604](#3604)
[Bug] MSAL.NativeInterop only targets .net fwk [See #3612](#3612)
@gladjohn gladjohn mentioned this issue Aug 26, 2022
Merged
1 task
@pmaytak pmaytak modified the milestones: 4.47.0, 4.46.2 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neha-bhargava neha-bhargava

Labels
Feature Request ICM This issue has a corresponding ICM, either for our team or another.
Projects
MSAL.NET Customer Trust
Archived in project
Milestone
4.46.2
Development

Successfully merging a pull request may close this issue.

Log exceptions to telemetry AzureAD/microsoft-authentication-library-for-dotnet
3 participants
@bgavrilMS @pmaytak @neha-bhargava