Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MSAL sends x-ms-pkeyauth header on Mac and Linux #4445

Closed
bgavrilMS opened this issue Dec 1, 2023 · 0 comments · Fixed by #4450
Closed

[Bug] MSAL sends x-ms-pkeyauth header on Mac and Linux #4445

bgavrilMS opened this issue Dec 1, 2023 · 0 comments · Fixed by #4450

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Dec 1, 2023

Library version used

4.58

.NET version

NET 7

Scenario

PublicClient - desktop app, ConfidentialClient - web site (AcquireTokenByAuthCode), ConfidentialClient - web api (AcquireTokenOnBehalfOf), ConfidentialClient - service to service (AcquireTokenForClient)

Is this a new or an existing app?

None

Issue description and reproduction steps

On Mac OS, sometimes it errors out as ESTS thinks MSAL is capable of sedning PKeyAuth proof.

Relevant code snippets

Bug is here:

https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/src/client/Microsoft.Identity.Client/OAuth2/TokenClient.cs#L187

The logic is wrong, as it returns: !IsWin10OrServerEquivalent i.e. IsWindows() && IsWin10Plus()

But on Mac this evaluates to TRUE, since IsWindows returns false.

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response

@bgavrilMS bgavrilMS added untriaged Do not delete. Needed for Automation needs attention Delete label after triage bug P2 confidential-client public-client and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels Dec 1, 2023
@bgavrilMS bgavrilMS self-assigned this Dec 4, 2023
@bgavrilMS bgavrilMS added this to the 4.59.0 milestone Dec 4, 2023
@pmaytak pmaytak modified the milestones: 4.59.0, 4.58.1 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment