Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for system browser on netcore #1142

Merged
merged 6 commits into from
May 15, 2019
Merged

Support for system browser on netcore #1142

merged 6 commits into from
May 15, 2019

Conversation

bgavrilMS
Copy link
Member

@bgavrilMS bgavrilMS commented May 10, 2019 •
edited

First commit is just a refactoring, lots of code changes, but little impact. Second commit brings default browser on .net core.

What's remaining:

  • (DONE) more unit tests (has a happy path unit test to show that the code is testable)
  • E2E testing on Mac (DONE) and Linux (DONE)
  • Support on .NetStandard, .Net classic and UAP
  • Configuration of success / failure messages
  • Configuration of redirect pages in case of success / failure
  • Configuration of how we invoke the browser (i.e. what command line to use), to have better control over WAM friendly browsers.

@bgavrilMS bgavrilMS requested review from MarkZuber, jennyf19, henrik-me and trwalke and removed request for MarkZuber and jennyf19 May 10, 2019 18:41
henrik-me
henrik-me reviewed May 13, 2019
View reviewed changes
src/Microsoft.Identity.Client/Platforms/Android/AuthenticationContinuationHelper.cs
return new AuthorizationResult(AuthorizationStatus.UnknownError, null);
}
}
case AndroidConstants.AuthCodeReceived:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Not sure why these are android consts. couldn't these be the same consts across all platforms?

MarkZuber
MarkZuber reviewed May 13, 2019
View reviewed changes
LibsUnix.sln Outdated Show resolved Hide resolved
@trwalke
Copy link
Member

trwalke commented May 13, 2019 

// Copyright (c) Microsoft Corporation. All rights reserved.

Extra spaces here

Refers to: src/Microsoft.Identity.Client/Platforms/netcore/OsBrowser/TcpInterceptor.cs:1 in 0c2b977. [](commit_id = 0c2b977, deletion_comment = False)

@bgavrilMS bgavrilMS merged commit 1c9147e into master May 15, 2019
@bgavrilMS bgavrilMS deleted the bogavril/sysbrowser branch May 15, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkZuber MarkZuber MarkZuber left review comments

@trwalke trwalke trwalke left review comments

@henrik-me henrik-me henrik-me left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgavrilMS @trwalke @MarkZuber @henrik-me