Implementing sendX5C on silent client credential call #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
May 22, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
May 22, 2019
src/Microsoft.Identity.Client/ApiConfig/AcquireTokenSilentParameterBuilder.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
May 22, 2019
|
|
||
|
|
||
|
|
||
| _tokenCacheHelper.PopulateCache(app.UserTokenCacheInternal.Accessor); |
There was a problem hiding this comment.
Would be better to mock an actual call instead of populating the token cache artificially.
There was a problem hiding this comment.
Not sure I understand the reason why? The functionality that is being testing is whether or not the x5c claim is present in the header of the acquire token silent request. How the user token made its way to the cache is irrelevant. Also, there are other acquire token silent tests that do the same thing.
There was a problem hiding this comment.
Not blocking the fix on this, but the arguments would be:
- artificially populating the cache makes it difficult to the test reader to understand what's in the cache
- cache population logic is quite likely to become different than how MSAL populates the cache (e.g. pretty sure this won't add AppMetadata which is a FOCI concept).
- overall test logic is cleaner because it's closer to what the user would do, i.e. fetch a token, fetch smth silent. The user does not "populate the cache".
bgavrilMS
reviewed
May 22, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
May 22, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
May 22, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Show resolved
Hide resolved
bgavrilMS
requested changes
May 22, 2019
MarkZuber
suggested changes
May 22, 2019
added 2 commits
May 22, 2019 11:58
adding additional test validation.
jennyf19
reviewed
May 23, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
May 23, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Show resolved
Hide resolved
MarkZuber
reviewed
May 23, 2019
MarkZuber
reviewed
May 23, 2019
tests/Microsoft.Identity.Test.Unit.net45/PublicApiTests/ClientCredentialWithCertTest.cs
Outdated
Show resolved
Hide resolved
|
ok, from me. however still open comments |
refactoring for PR comments.
bgavrilMS
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding withsendX5C() on acquire token silent for the confidential client application
#1149