Pop implementation for Confidential Client #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you consider refactoring for re-use across net desktop and net core? |
@henrik-me yes. Netcore is implemented here. one more commit to push |
bgavrilMS
reviewed
Aug 13, 2020
...icrosoft.Identity.Client/ApiConfig/AbstractConfidentialClientAcquireTokenParameterBuilder.cs
Outdated
Show resolved
Hide resolved
|
I still see potential for refactoring's as there is code duplication which can be avoided. In reply to: 673187877 [](ancestors = 673187877) |
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 13, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
bgavrilMS
reviewed
Aug 17, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
tests/Microsoft.Identity.Test.Unit.net45/pop/PopAuthenticationSchemeTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 17, 2020
src/client/Microsoft.Identity.Client/Platforms/netcore/NetCorePoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 19, 2020
bgavrilMS
reviewed
Aug 19, 2020
src/client/Microsoft.Identity.Client/PlatformsCommon/NetSharedPoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 19, 2020
src/client/Microsoft.Identity.Client/PlatformsCommon/NetSharedPoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 19, 2020
src/client/Microsoft.Identity.Client/PlatformsCommon/NetSharedPoPCryptoProvider.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Aug 19, 2020
tests/Microsoft.Identity.Test.Unit.net45/pop/PopAuthenticationSchemeTests.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Aug 19, 2020
bgavrilMS
approved these changes
Aug 20, 2020
adding netcore implementation
Fixing key rotation issue. Adding surface for CCA
missing file change
addressing PR comments
bgavrilMS
reviewed
Aug 21, 2020
| /// <summary> | ||
| /// The default implementation will store a key in memory | ||
| /// </summary> | ||
| internal class InMemoryCryptoProvider : IPoPCryptoProvider |
There was a problem hiding this comment.
@trwalke - as discussed, here's a suggestion on how to deal with the key expiration, since the crypto provider must always provide details about the same public / private key pair.
I moved your expiration logic to another class.
bgavrilMS
reviewed
Aug 21, 2020
| internal /* internal for test only */ const int RsaKeySize = 2048; | ||
|
|
||
|
|
||
| #if NET45 |
There was a problem hiding this comment.
we now target both .net45 and .net 461, and in .net 461 the RSA.Create() works fine.
bgavrilMS
reviewed
Aug 21, 2020
| /// <summary> | ||
| /// This factory ensures key rotation every 8h | ||
| /// </summary> | ||
| internal class PoPProviderFactory |
There was a problem hiding this comment.
I moved expiration logic here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1946