process android broker error codes which should result in UI required… #2200
Conversation
| @@ -44,5 +44,7 @@ internal static class BrokerResponseConst | |||
|
|
|||
| //Error codes returned from broker | |||
| public const string NoTokenFound = "no_tokens_found"; | |||
| public const string NoAccountFound = "no_account_found"; | |||
| public const string InvalidRefreshToken = "Broker refresh token is invalid"; | |||
There was a problem hiding this comment.
not sure if this is legit, i used the error codes from the customer's screen shot. #Resolved
There was a problem hiding this comment.
It's legit :( Both Android broker and B2C miss the point of "error code" and send full blown messages :( #Resolved
| @@ -79,7 +79,9 @@ private async Task<MsalTokenResponse> SendTokenRequestToBrokerAsync() | |||
| _logger.Info( | |||
| LogMessages.ErrorReturnedInBrokerResponse(msalTokenResponse.Error)); | |||
|
|
|||
| if (msalTokenResponse.Error == BrokerResponseConst.NoTokenFound) | |||
| if (msalTokenResponse.Error == BrokerResponseConst.NoTokenFound || | |||
There was a problem hiding this comment.
Could you prefix these constants with "Android"? #Resolved
There was a problem hiding this comment.
| } | ||
|
|
||
| [TestMethod] | ||
| public void NoAccountFoundThrowsUIRequiredTest() |
There was a problem hiding this comment.
I was thinking that the best place to add this the logic you've added is actually in AndroidBroker.cs; However we can't test that. Having tests beats a marginally better architecture. #Resolved
There was a problem hiding this comment.
+1 to the unit testing, especially since not sure how to manually test w/out messing up my authenticator app.
In reply to: 526108961 [](ancestors = 526108961)
… exceptions
not sure if this is what you guys want to do here. #2140 also, did not test on a device as I only have my personal pixel and don't want to mess up the authenticator app. :/