Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling MSAL to read federation metadata #2647

Merged
merged 16 commits into from
May 27, 2021

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented May 20, 2021

Enabling MSAL to read federation metadata form a file provided by the developer.
Correcting MessageID character casing.

Partial fix for #2152

Copy link
Contributor

@neha-bhargava neha-bhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and a question, otherwise looks good.

Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of scope for this issue, and I'm not super familiar with this WS-Trust - we seem to get the metadata on every request (either file or from web). Is there a benefit to cache metadata or does it have to be retrieved each time?

trwalke and others added 11 commits May 24, 2021 16:17
…ntegratedWindowsAuthParameterBuilder.cs

Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…ntegratedWindowsAuthParameterBuilder.cs

Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…sernamePasswordParameterBuilder.cs

Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…sernamePasswordParameterBuilder.cs

Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com>
# Conflicts:
#	src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
#	src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByUsernamePasswordParameterBuilder.cs
@bgavrilMS
Copy link
Member

LGTM, but we should also add a unit test around AcquireTokenByIntegratedWindowsAuth, similar to

. This will at least ensure that MSAL does not make the HTTP call to get the mex document.

Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment changes + needs another unit test.

trwalke added 2 commits May 25, 2021 15:52
Adding IWA unit test
@bgavrilMS bgavrilMS merged commit 0dfa2c9 into master May 27, 2021
@bgavrilMS bgavrilMS deleted the trwalke/federationMetadaUpdates branch May 27, 2021 09:07
@bgavrilMS bgavrilMS linked an issue May 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WS-Fed ability to import federationmetadata.xml from 3rd party IDPs
4 participants