-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling MSAL to read federation metadata #2647
Conversation
… developer. Correcting MessageID character casing.
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByUsernamePasswordParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByUsernamePasswordParameterBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/WsTrust/WsTrustWebRequestManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments and a question, otherwise looks good.
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of scope for this issue, and I'm not super familiar with this WS-Trust - we seem to get the metadata on every request (either file or from web). Is there a benefit to cache metadata or does it have to be retrieved each time?
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
…ntegratedWindowsAuthParameterBuilder.cs Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…ntegratedWindowsAuthParameterBuilder.cs Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…sernamePasswordParameterBuilder.cs Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…sernamePasswordParameterBuilder.cs Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
Co-authored-by: pmaytak <34331512+pmaytak@users.noreply.github.com>
# Conflicts: # src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs # src/client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByUsernamePasswordParameterBuilder.cs
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...t/Microsoft.Identity.Client/ApiConfig/AcquireTokenByIntegratedWindowsAuthParameterBuilder.cs
Outdated
Show resolved
Hide resolved
...client/Microsoft.Identity.Client/ApiConfig/AcquireTokenByUsernamePasswordParameterBuilder.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/WsTrust/WsTrustWebRequestManager.cs
Outdated
Show resolved
Hide resolved
...crosoft.Identity.Test.Integration.netcore/Microsoft.Identity.Test.Integration.NetCore.csproj
Show resolved
Hide resolved
.../Microsoft.Identity.Test.Integration.netfx/HeadlessTests/UsernamePasswordIntegrationTests.cs
Show resolved
Hide resolved
LGTM, but we should also add a unit test around AcquireTokenByIntegratedWindowsAuth, similar to Line 250 in 52dbbcc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment changes + needs another unit test.
Adding IWA unit test
Enabling MSAL to read federation metadata form a file provided by the developer.
Correcting MessageID character casing.
Partial fix for #2152