Handle case when b2c profile contains a '.' #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-bhargava
commented
May 21, 2021
| { | ||
| return new AccountId(str); //Account id is from ADFS; no . in the string | ||
| } | ||
|
|
||
| return new AccountId(str, elements[0], elements[1]); | ||
| return new AccountId(str, str.Substring(0, lastIndexOfDot), str.Substring(lastIndexOfDot + 1)); |
There was a problem hiding this comment.
This is the fix, splitting the string based on the last .
neha-bhargava
commented
May 21, 2021
| @@ -117,7 +117,7 @@ public async Task<IEnumerable<IAccount>> GetAccountsAsync(string userFlow) | |||
| var accounts = await GetAccountsInternalAsync(ApiIds.GetAccountsByUserFlow).ConfigureAwait(false); | |||
|
|
|||
| return accounts.Where(acc => | |||
| acc.HomeAccountId.ObjectId.Split('.')[0].EndsWith( | |||
| acc.HomeAccountId.ObjectId.EndsWith( | |||
There was a problem hiding this comment.
I don't see the reason for adding this split here as the ObjectId is obtained after splitting the homeAccountId with the .
bgavrilMS
reviewed
May 21, 2021
bgavrilMS
approved these changes
May 21, 2021
pmaytak
approved these changes
May 22, 2021
tests/Microsoft.Identity.Test.Unit/PublicApiTests/AccountIdTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2444
Try to handle the scenario when the b2c profile have a '.' character.