Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore region outside client_credentials flow #3023

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

jennyf19
Copy link
Collaborator

@jennyf19 jennyf19 commented Nov 18, 2021

AT by Auth code does not work, and I imagine AT by RT will be the same

MsalServiceException: AADSTS70003: The app requested an unsupported grant type 'authorization_code'.

@jennyf19 jennyf19 marked this pull request as ready for review November 18, 2021 03:25
@bgavrilMS
Copy link
Member

Thanks for the contribution @jennyf19 . In order to speed up the release, I added more unit tests and integration tests to cover E2E obo and auth_code flows.

I am merging this PR as soon as it's ready. @pmaytak @trwalke @SameerK-MSFT - please review and if you see any big issues we will stop the release. Smaller issues we can take care in MSAL 4.38.1.

@bgavrilMS bgavrilMS changed the title skip region when doing OBO Ignore region outside client_credentials flow Nov 18, 2021
@bgavrilMS bgavrilMS merged commit 87de2a9 into master Nov 18, 2021
@trwalke trwalke linked an issue Nov 18, 2021 that may be closed by this pull request
7 tasks
@bgavrilMS bgavrilMS deleted the jennyf/skipRegionForObo branch April 7, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] MSAL should ignore region outside client_credentials flow
2 participants