Fix for #3294 - throw UiRequiredException when WAM cannot get a trans… #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer token in MSA-PT
jmprieur
reviewed
May 5, 2022
src/client/Microsoft.Identity.Client/Platforms/Features/WamBroker/WamBroker.cs
Outdated
Show resolved
Hide resolved
pmaytak
reviewed
May 6, 2022
There was a problem hiding this comment.
What is the current behavior? What is the new behavior? What are the benefits of the new behavior?
- ATS for default OS MSA account in MSA-PT scenario -> can show a UI.
- Same scenario but now instead of UI showing up whenever, dev can catch the UiRequired exception and not show the UI?
SameerK-MSFT
approved these changes
May 9, 2022
neha-bhargava
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fer token in MSA-PT
Fixes #3294
Changes proposed in this request
Testing
Performance impact