-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IsProofOfPosessionSupportedByClient api #3581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently for the desktop broker we show "The broker does not support Proof-of-Possession on the current platform.", we can extend this message asking developers to adopt to the new broker if they need PoP support.
src/client/Microsoft.Identity.Client/PublicClientApplication.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Unit/PublicApiTests/PublicClientApplicationTests.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change updating the public IPCA interface. Was that discussed and okay'ed?
tests/Microsoft.Identity.Test.Unit/PublicApiTests/PublicClientApplicationTests.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
Spec also mentions to throw an exception with the recommendation to use IsPopSupported method if incorrect usage of WithPop is detected. |
src/client/Microsoft.Identity.Client/PublicClientApplication.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/IPublicClientApplication.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation of helper needs changes.
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
# Conflicts: # src/client/Microsoft.Identity.Client/IPublicClientApplication.cs # src/client/Microsoft.Identity.Client/PublicClientApplication.cs
@pmaytak I dont think I see that In the spec. There is something related to that in the appendix for the higher level api but it is not required for the low level api proposed in proposal 2 |
@trwalke Don't exactly remember what I was referring to, but maybe it was the second acceptance test. Currently in |
@pmaytak |
tests/Microsoft.Identity.Test.Integration.netfx/HeadlessTests/PoPTests.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/PublicClientApplication.cs
Outdated
Show resolved
Hide resolved
Did some additional thinking on this and I think there are a few more exceptions that need to be thrown to satisfy the exception tests. Acceptance tests
Specifically, the last 2. I made some updates to reflect that. |
Fixes #
fix for #3496
Changes proposed in this request
Adding api for IsProofOfPosessionSupportedByClient to be used to determine if the current broker is able to support POP
Testing
Unit test
Performance impact
N/A
Documentation