Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose WAM telemetry in AuthenticationResult and exceptions #4307

Merged
merged 13 commits into from
Sep 5, 2023
Merged

Expose WAM telemetry in AuthenticationResult and exceptions #4307

merged 13 commits into from
Sep 5, 2023

Conversation

bgavrilMS
Copy link
Member

Expose WAM telemetry #4159

@bgavrilMS bgavrilMS marked this pull request as draft August 18, 2023 15:15
@bgavrilMS bgavrilMS requested a review from crmann1 August 18, 2023 15:26
@bgavrilMS bgavrilMS marked this pull request as ready for review August 18, 2023 15:26
@bgavrilMS bgavrilMS changed the title Add WAM telemetry to AuthResult Expose WAM telemetry in AuthenticationResult and exceptions Aug 18, 2023
iulico-1
iulico-1 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@iulico-1 iulico-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

pmaytak
pmaytak reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on telemetry property name, if you want to take it, but I won't block the PR for it.

@bgavrilMS bgavrilMS enabled auto-merge (squash) September 1, 2023 21:56
pmaytak
pmaytak approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property in the tests needs to be changed.

ashok672
ashok672 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ashok672 ashok672 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bgavrilMS bgavrilMS merged commit 29cbbb0 into main Sep 5, 2023
6 checks passed
@bgavrilMS bgavrilMS deleted the bogavril/4159 branch September 5, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulico-1 iulico-1 iulico-1 approved these changes

@gladjohn gladjohn gladjohn approved these changes

@pmaytak pmaytak pmaytak approved these changes

@ashok672 ashok672 ashok672 approved these changes

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@trwalke trwalke Awaiting requested review from trwalke

@crmann1 crmann1 Awaiting requested review from crmann1

@localden localden Awaiting requested review from localden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bgavrilMS @crmann1 @pmaytak @iulico-1 @localden @ashok672 @gladjohn