Fall back to local cache if broker fails to return result for silent token call #4395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Oct 26, 2023
src/client/Microsoft.Identity.Client/Internal/Requests/Silent/SilentRequest.cs
Show resolved
Hide resolved
github-actions
bot
requested review from
bgavrilMS,
gladjohn,
neha-bhargava,
pmaytak and
trwalke
rayluo
approved these changes
Nov 2, 2023
bgavrilMS
approved these changes
Nov 2, 2023
bgavrilMS
deleted the
asram/fallback-local-cache-when-broker-silenttoken-fails
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4209
Changes proposed in this request
WithBroker = true, interactive token call falls back correctly to browser and completes the flow. With silent token call for the same account, currently there is no fallback to local cache if broker fails to return result. BrokerStrategy can fail for example if the broker is not available in the machine. The fix is to fall back to local cache for silent token call as well similar to interactive call.
Testing
The existing unit tests were modified to account for the new bahavior
Ran through the scenario manually in the WinForms test app and verified its working as expected
Performance impact
None
Documentation
None