Add support for MSA passthrough for silent token acquisition calls through the boker #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bgavrilMS,
neha-bhargava,
pmaytak and
trwalke
iulico-1
requested review from
ashok672 and
bgavrilMS
and removed request for
bgavrilMS,
trwalke,
pmaytak and
neha-bhargava
|
@iulico-1 - could you please open a bug or feature request on MSAL.NET and associate it with this PR? This is so that the change gets included in the release notes. |
bgavrilMS
reviewed
Nov 15, 2023
tests/Microsoft.Identity.Test.Unit/CoreTests/InstanceTests/AadAuthorityTests.cs
Outdated
Show resolved
Hide resolved
…AuthorityTests.cs Async methods should be suffixed with "async" (enforced by an analyzer)
bgavrilMS
force-pushed
the
iulico/fix-msa-passthrough-broker
branch
from
d22ae22
to
3f6b099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4425
Currently MSA passthrough doesn't work as expected for silent token acquisition flows because MSAL.net normalizes /organizations authority using accounts home tenant. This logic made sense for V1 requests, but it breaks MSA passthrough flows using the runtime.
Changes proposed in this request
Stop normalizing /organizations authority for MSA passthrough flows.
Testing
Unit and component tests added.
Performance impact
Negligible