Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #4444 - emit simple OS descriptor #4449

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Fix for #4444 - emit simple OS descriptor #4449

merged 6 commits into from
Dec 7, 2023

Conversation

bgavrilMS
Copy link
Member

Fixes #4444

@bgavrilMS
Copy link
Member Author

bgavrilMS commented Dec 4, 2023 •
edited

Let me know if the new values "Windows", "MacOS", "Linux" are ok, happy to change to anything is easy ESTS, @jbzdarkid

Note that for Windows the current string is like "Microsoft Windows 10.0.16620.0" (at least .NET Core), but I would think ESTS doesn't look at the Win Version in x-client-os.

@rayluo
Copy link
Contributor

rayluo commented Dec 4, 2023

Let me know if the new values "Windows", "MacOS", "Linux" are ok, happy to change to anything is easy ESTS, @jbzdarkid

Note that for Windows the current string is like "Microsoft Windows 10.0.16620.0" (at least .NET Core), but I would think ESTS doesn't look at the Win Version in x-client-os.

Do those values need to be precisely defined by eSTS? I thought they are kind of freestyle. For example, in MSAL Python it is the output of Python's built-in sys.platform value, whose values are described here. Do we have to let all MSALs use same set of values?

iulico-1
iulico-1 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@iulico-1 iulico-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bgavrilMS bgavrilMS merged commit 072ad20 into main Dec 7, 2023
6 checks passed
@bgavrilMS bgavrilMS deleted the bogavril/4444 branch December 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbzdarkid jbzdarkid jbzdarkid left review comments

@pmaytak pmaytak pmaytak approved these changes

@iulico-1 iulico-1 iulico-1 approved these changes

@gladjohn gladjohn Awaiting requested review from gladjohn

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@trwalke trwalke Awaiting requested review from trwalke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] AcquireTokenSilent call is failing on Mac because of missing OperatingSystem information
5 participants
@bgavrilMS @rayluo @jbzdarkid @pmaytak @iulico-1