Use linked cancellation token source during proactive refresh. #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bgavrilMS,
gladjohn,
neha-bhargava and
trwalke
|
Alternative solution to passing a cancellation token is not to propagate the cancellation to the proactive refresh since it's kind of a fire-and-forget background operation. The reasoning for passing the cancellation is since the original operation was canceled, perhaps all related operations should be canceled too. |
bgavrilMS
approved these changes
Dec 21, 2023
bgavrilMS
reviewed
Dec 21, 2023
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Show resolved
Hide resolved
gladjohn
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4473
Changes proposed in this request
Testing
Performance impact
N/A
Documentation