Handle error response from cloud shell and add tests #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bgavrilMS,
gladjohn,
pmaytak and
trwalke
gladjohn
reviewed
Feb 22, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Feb 22, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Feb 22, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
reviewed
Feb 22, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
gladjohn
reviewed
Feb 22, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Feb 27, 2024
gladjohn
approved these changes
Feb 28, 2024
src/client/Microsoft.Identity.Client/ManagedIdentity/AbstractManagedIdentity.cs
Outdated
Show resolved
Hide resolved
…anagedIdentity.cs Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
bgavrilMS
force-pushed
the
nebharg/msiCloudShellFix
branch
from
a3e7221
to
2c81d21
Compare
gladjohn
approved these changes
Mar 1, 2024
|
@neha-bhargava - anything pending on this one? |
No, just the builds. Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4402
Changes proposed in this request
Testing
Updated unit tests
Performance impact
Documentation