Update nuget packages, MonoAndroid9, Xamarin 28, XForms 3.x #838
Conversation
| @@ -42,7 +42,7 @@ public class MobileTestHelper | |||
| private string _acquirePageId; | |||
| private string _cachePageId; | |||
| private string _settingsPageId; | |||
| private string _logPageId; | |||
| // private string _logPageId; | |||
LibsAndSamples.sln
Outdated
| @@ -1,6 +1,6 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 15 | |||
| # Visual Studio 15 # Visual Studio Version 16 | |||
There was a problem hiding this comment.
Visual Studio Version 16 [](start = 19, length = 26)
should this be included? #Resolved
src/MSAL.Frameworks.props
Outdated
| @@ -1,16 +1,16 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <TargetFrameworkNetDesktop>net45</TargetFrameworkNetDesktop> | |||
| <TargetFrameworkNetDesktop>net461</TargetFrameworkNetDesktop> | |||
There was a problem hiding this comment.
net461 [](start = 31, length = 6)
JM?
There was a problem hiding this comment.
@jmprieur can you provide validation/signoff that moving to net461 for net desktop is acceptable for 3.x?
| @@ -134,7 +134,7 @@ | |||
| </ItemGroup> | |||
| <Import Project="$(MSBuildExtensionsPath)\Xamarin\Android\Xamarin.Android.CSharp.targets" /> | |||
| <!-- Import the Xamarin targets workaround --> | |||
| <Import Project="..\Patch.Xamarin.Common.targets" /> | |||
| <!-- <Import Project="..\Patch.Xamarin.Common.targets" /> --> | |||
|
@MarkZuber we'll have to update the build machines to handle monoandroid9 #Pending |
| <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.2" /> | ||
| <PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="4.4.2" /> | ||
| <PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.3" /> | ||
| <PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="4.5.0" /> |
There was a problem hiding this comment.
[](start = 4, length = 94)
we should really move this to use MSAL #WontFix
There was a problem hiding this comment.
Agreed. Is the lab available on v2 endpoint where we can move this?
In reply to: 251185053 [](ancestors = 251185053)
There was a problem hiding this comment.
MSAL can get tokens which are for a v1 SDK. The AT will likely be v1 (but as a developer you shouldn't have to worry about that) and the service will be able to use existing code to validate the tokens. The app should be available on v2. #WontFix
There was a problem hiding this comment.
ADAL is needed here not to access the lab, but KeyVault. If we come up with a solution for accessing KeyVault using MSAL, it would be a big impact since Azure is pushing KeyVault strongly and a lot of developers experience AAD because of KV. #WontFix
There was a problem hiding this comment.
msal c++ is using themselves to talk to the keyvault for test automation so it should be possible. Travis was going to look into updating the callback token acquisition in the keyvault code to see if we can use msal there. but that wno't be part of this PR so i'm going to close this comment stream out and we can discuss it in parallel.
In reply to: 251940425 [](ancestors = 251940425)
|
Good point. Will do this as part of validating the builds for checkin. Are instructions for "how to update the build machines" on the wiki/onenote? In reply to: 457793269 [](ancestors = 457793269) |
| @@ -20,7 +21,14 @@ | |||
| <PropertyGroup Condition="'$(TargetFramework)' == '$(TargetFrameworkNetStandard)'"> | |||
| <DefineConstants>$(DefineConstants);NETSTANDARD_RUNTIME</DefineConstants> | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
There was a problem hiding this comment.
Can't we place these in the common.props file?
There was a problem hiding this comment.
nuget doesn't put them there when doing a package update. we can talk about moving them, but that means we have to do that every time we update our packages.
In reply to: 251941091 [](ancestors = 251941091)
MarkZuber
changed the title
No description provided.